Github user ala commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16872#discussion_r100347811
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
    @@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest with 
SharedSQLContext {
           }
         }
       }
    +
    +  test("Cancelling stage in a query with Range.") {
    +    val listener = new SparkListener {
    +      override def onTaskStart(taskStart: SparkListenerTaskStart): Unit = {
    +        Thread.sleep(100)
    --- End diff --
    
    The only other thing in the SparkListener interface that seems to fit here 
seems to be `onExecutorMetricsUpdate()`. However, the metrics are send with the 
heartbeats, and the heartbeats are send around 10s apart. Hence, using this 
method makes the tests much slower (4s vs 20s).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to