Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16865#discussion_r100422867
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1004,7 +1016,8 @@ object CodeGenerator extends Logging {
        * weak keys/values and thus does not respond to memory pressure.
        */
       private val cache = CacheBuilder.newBuilder()
    -    .maximumSize(100)
    +    .maximumWeight(10 * 1024 * 1024)
    --- End diff --
    
    Hi, @viirya . If this is configured as 10MB, we can have 160 cached items 
with each 64KB code.
    It looks like this patch will make Spark consume more memory than the 
existing one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to