Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1279#discussion_r17459005
  
    --- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -81,6 +81,10 @@ class Client(clientArgs: ClientArguments, hadoopConf: 
Configuration, spConf: Spa
         appContext.setQueue(args.amQueue)
         appContext.setAMContainerSpec(amContainer)
         appContext.setApplicationType("SPARK")
    +    sparkConf.getOption("spark.yarn.maxappattempts").map(_.toInt) match {
    --- End diff --
    
    its not the number of application submission attempts though, this is how 
many times the resource manager will retry the application for you.  to me 
application submission is done by the client, not a retry from the RM.  what 
isn't clear about the current one so we can come up with something more clear? 
We could do something like ApplicationMasterMaxAttempts, am-maxattempts, 
rmappattempts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to