Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16871#discussion_r100645304
  
    --- Diff: project/SparkBuild.scala ---
    @@ -765,16 +750,6 @@ object CopyDependencies {
     
     }
     
    -object Java8TestSettings {
    -  import BuildCommons._
    -
    -  lazy val settings = Seq(
    -    javacJVMVersion := "1.8",
    -    // Targeting Java 8 bytecode is only supported in Scala 2.11.4 and 
higher:
    -    scalacJVMVersion := (if (System.getProperty("scala-2.10") == "true") 
"1.7" else "1.8")
    --- End diff --
    
    I see, so we need scalac to target 1.7 byte code for the Scala code it 
emits in 2.10. That would be fine for moving to Java 8 if javac (8) were 
handling Java code using Java 8, because the result would just be a mix of 7 
and 8 bytecode but no big deal. Do I have that right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to