Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16386#discussion_r100679183
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1764,4 +1769,117 @@ class JsonSuite extends QueryTest with
SharedSQLContext with TestJsonData {
val df2 = spark.read.option("PREfersdecimaL", "true").json(records)
assert(df2.schema == schema)
}
+
+ test("SPARK-18352: Parse normal multi-line JSON files (compressed)") {
+ withTempPath { dir =>
+ val path = dir.getCanonicalPath
+ primitiveFieldAndType
+ .toDF("value")
+ .write
+ .option("compression", "GzIp")
+ .text(path)
+
+ assert(new File(path).listFiles().exists(_.getName.endsWith(".gz")))
+
+ val jsonDF = spark.read.option("wholeFile", true).json(path)
--- End diff --
I mean we should check answer with `jsonDF`, instead of writing `jsonDF`
out and read it back as `jsonCopy` and test the result.
The problem is, if `jsonDF` is already wrong, then it's meaningless to
write it out and read it back, which can still pass the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
