Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100737587
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -75,7 +75,7 @@ class JDBCWriteSuite extends SharedSQLContext with
BeforeAndAfter {
s"""
|CREATE OR REPLACE TEMPORARY VIEW PEOPLE1
|USING org.apache.spark.sql.jdbc
- |OPTIONS (url '$url1', dbtable 'TEST.PEOPLE1', user 'testUser',
password 'testPass')
+ |OPTIONS (url '$url1', dbTable 'TEST.PEOPLE1', user 'testUser',
password 'testPass')
--- End diff --
Yes, they should be case-insensitive. Just additional case-sensitivity
test case.
During testing of my fix I did not notice a test in the write suite for
data source table for case-sensitivity checking during insert. I flipped the
"dbTable" to make sure case-insensitivity is not broken in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
