Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16672#discussion_r100882612
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1816,4 +1816,127 @@ class DDLSuite extends QueryTest with
SharedSQLContext with BeforeAndAfterEach {
}
}
}
+
+ test("insert data to a data source table which has a not existed
location should succeed") {
+ withTable("t") {
+ withTempDir { dir =>
+ spark.sql(
+ s"""
+ |CREATE TABLE t(a string, b int)
+ |USING parquet
+ |OPTIONS(path "file:${dir.getCanonicalPath}")
+ """.stripMargin)
+ val table =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+ val expectedPath = s"file:${dir.getAbsolutePath.stripSuffix("/")}"
+ assert(table.location.stripSuffix("/") == expectedPath)
+
+ dir.delete
+ val tableLocFile = new File(table.location.stripPrefix("file:"))
+ assert(!tableLocFile.exists)
+ spark.sql("INSERT INTO TABLE t SELECT 'c', 1")
+ assert(tableLocFile.exists)
+ checkAnswer(spark.table("t"), Row("c", 1) :: Nil)
+
+ Utils.deleteRecursively(dir)
+ assert(!tableLocFile.exists)
+ spark.sql("INSERT OVERWRITE TABLE t SELECT 'c', 1")
+ assert(tableLocFile.exists)
+ checkAnswer(spark.table("t"), Row("c", 1) :: Nil)
+
+ val newDir = dir.getAbsolutePath.stripSuffix("/") + "/x"
+ val newDirFile = new File(newDir)
+ spark.sql(s"ALTER TABLE t SET LOCATION '$newDir'")
+ spark.sessionState.catalog.refreshTable(TableIdentifier("t"))
+
+ val table1 =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+ assert(table1.location == newDir)
+ assert(!newDirFile.exists)
+
+ spark.sql("INSERT INTO TABLE t SELECT 'c', 1")
+ assert(newDirFile.exists)
+ checkAnswer(spark.table("t"), Row("c", 1) :: Nil)
+ }
+ }
+ }
+
+ test("insert into a data source table with no existed partition location
should succeed") {
+ withTable("t") {
+ withTempDir { dir =>
+ spark.sql(
+ s"""
+ |CREATE TABLE t(a int, b int, c int, d int)
+ |USING parquet
+ |PARTITIONED BY(a, b)
+ |LOCATION "file:${dir.getCanonicalPath}"
+ """.stripMargin)
+ val table =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+ val expectedPath = s"file:${dir.getAbsolutePath.stripSuffix("/")}"
+ assert(table.location.stripSuffix("/") == expectedPath)
+
+ spark.sql("INSERT INTO TABLE t PARTITION(a=1, b=2) SELECT 3, 4")
+ checkAnswer(spark.table("t"), Row(3, 4, 1, 2) :: Nil)
+
+ val partLoc = new File(s"${dir.getAbsolutePath}/a=1")
+ Utils.deleteRecursively(partLoc)
+ assert(!partLoc.exists())
+ // insert overwrite into a partition which location has been
deleted.
+ spark.sql("INSERT OVERWRITE TABLE t PARTITION(a=1, b=2) SELECT 7,
8")
+ assert(partLoc.exists())
+ checkAnswer(spark.table("t"), Row(7, 8, 1, 2) :: Nil)
+
+ // TODO:insert into a partition after alter the partition location
by alter command
+ }
+ }
+ }
+
+ test("read data from a data source table which has a not existed
location should succeed") {
+ withTable("t") {
+ withTempDir { dir =>
+ spark.sql(
+ s"""
+ |CREATE TABLE t(a string, b int)
+ |USING parquet
+ |OPTIONS(path "file:${dir.getAbsolutePath}")
+ """.stripMargin)
+ val table =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+ val expectedPath = s"file:${dir.getAbsolutePath.stripSuffix("/")}"
+ assert(table.location.stripSuffix("/") == expectedPath)
+
+ dir.delete()
+ checkAnswer(spark.table("t"), Nil)
+
+ val newDir = dir.getAbsolutePath.stripSuffix("/") + "/x"
+ spark.sql(s"ALTER TABLE t SET LOCATION '$newDir'")
+
+ val table1 =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
+ assert(table1.location == newDir)
+ assert(!new File(newDir).exists())
+ checkAnswer(spark.table("t"), Nil)
+ }
+ }
+ }
+
+ test("read data from a data source table with no existed partition
location should succeed") {
+ withTable("t") {
+ withTempDir { dir =>
+ spark.sql(
+ s"""
+ |CREATE TABLE t(a int, b int, c int, d int)
+ |USING parquet
+ |PARTITIONED BY(a, b)
+ |LOCATION "file:${dir.getCanonicalPath}"
+ """.stripMargin)
+ val table =
spark.sessionState.catalog.getTableMetadata(TableIdentifier("t"))
--- End diff --
This is not being used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
