Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16891#discussion_r100910764
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala ---
@@ -75,7 +75,7 @@ class JDBCWriteSuite extends SharedSQLContext with
BeforeAndAfter {
s"""
|CREATE OR REPLACE TEMPORARY VIEW PEOPLE1
|USING org.apache.spark.sql.jdbc
- |OPTIONS (url '$url1', dbtable 'TEST.PEOPLE1', user 'testUser',
password 'testPass')
+ |OPTIONS (url '$url1', dbTable 'TEST.PEOPLE1', user 'testUser',
password 'testPass')
--- End diff --
This is not obvious. We might remove it in the future. How about adding a
dedicated test case in JDBCWriteSuite.scala?
https://github.com/sureshthalamati/spark/blob/a1560742f2196ba04c14ad50e955bdcc839c4ad8/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala#L249-L259
You can make the key name more obvious. Something like `DbTaBlE`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
