Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r100933844
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -106,18 +110,21 @@ class TrainValidationSplit @Since("1.5.0")
(@Since("1.5.0") override val uid: St
trainingDataset.cache()
validationDataset.cache()
- // multi-model training
logDebug(s"Train split with multiple sets of parameters.")
- val models = est.fit(trainingDataset, epm).asInstanceOf[Seq[Model[_]]]
+ // Fit models concurrently, limited by using a sliding window over
models
--- End diff --
perhaps add "sliding window of size 'numPar' over ..." - can add to all
instances of this comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
