Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16741#discussion_r100958021
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -135,13 +135,13 @@ abstract class MLWriter extends BaseReadWrite with
Logging {
}
/**
- * Trait for classes that provide [[MLWriter]].
+ * Trait for classes that provide `MLWriter`.
--- End diff --
@jkbradley, Yes, it seems fine for both.
I think I changed them given `sealed trait BaseReadWrite`...
```
[warn]
.../spark/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala:143:
Could not find any member to link for "MLWriter".
[warn] /**
[warn] ^
```
and I think I swept them here as they looked identical. I am okay to revive
identified ones back.
My (maybe nitpicking) concern is, we should be able to identify the cases
explicitly which I guess I and many guys failed and also what to do in each
case. Otherwise, I think we should prefer backquotes because even if reviving
links might work for now for some cases, we could easily introduce other breaks
again when we change the codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
