Github user Yunni commented on a diff in the pull request: https://github.com/apache/spark/pull/16715#discussion_r101089800 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala --- @@ -222,17 +222,18 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]] } /** - * Join two dataset to approximately find all pairs of rows whose distance are smaller than + * Join two datasets to approximately find all pairs of rows whose distance are smaller than * the threshold. If the [[outputCol]] is missing, the method will transform the data; if the * [[outputCol]] exists, it will use the [[outputCol]]. This allows caching of the transformed * data when necessary. * * @param datasetA One of the datasets to join. * @param datasetB Another dataset to join. * @param threshold The threshold for the distance of row pairs. - * @param distCol Output column for storing the distance between each result row and the key. + * @param distCol Output column for storing the distance between each pair of rows. * @return A joined dataset containing pairs of rows. The original rows are in columns - * "datasetA" and "datasetB", and a distCol is added to show the distance of each pair. + * "datasetA" and "datasetB", and a distCol is added to show the distance between each --- End diff -- Done.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org