Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2257#issuecomment-55405175
@vanzin this mostly looks good. I've been trying to run it locally but I
have been having lots of issues with the unit tests lately. Hopefully have
this done and check in later today.
Thanks for working on this, we definitely need more tests on the yarn side.
We may need to be careful about adding more in the future if they take to
longer, perhaps we can look at supporting the different types as you mention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
