Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16228#discussion_r101179517
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/JoinEstimationSuite.scala
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.statsEstimation
+
+import java.sql.{Date, Timestamp}
+
+import scala.collection.mutable
+
+import org.apache.spark.sql.catalyst.expressions.{And, Attribute,
AttributeMap, AttributeReference, EqualTo}
+import org.apache.spark.sql.catalyst.plans._
+import org.apache.spark.sql.catalyst.plans.logical.{ColumnStat, Join,
Project, Statistics}
+import
org.apache.spark.sql.catalyst.plans.logical.statsEstimation.EstimationUtils._
+import org.apache.spark.sql.types.{DateType, TimestampType, _}
+
+
+class JoinEstimationSuite extends StatsEstimationTestBase {
+
+ /** Set up tables and its columns for testing */
+ private val columnInfo: AttributeMap[ColumnStat] = AttributeMap(Seq(
+ attr("key-1-5") -> ColumnStat(distinctCount = 5, min = Some(1), max =
Some(5), nullCount = 0,
+ avgLen = 4, maxLen = 4),
+ attr("key-5-9") -> ColumnStat(distinctCount = 5, min = Some(5), max =
Some(9), nullCount = 0,
+ avgLen = 4, maxLen = 4),
+ attr("key-1-2") -> ColumnStat(distinctCount = 2, min = Some(1), max =
Some(2), nullCount = 0,
+ avgLen = 4, maxLen = 4),
+ attr("key-2-4") -> ColumnStat(distinctCount = 3, min = Some(2), max =
Some(4), nullCount = 0,
+ avgLen = 4, maxLen = 4),
+ attr("key-2-3") -> ColumnStat(distinctCount = 2, min = Some(2), max =
Some(3), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+ ))
+
+ private val nameToAttr: Map[String, Attribute] = columnInfo.map(kv =>
kv._1.name -> kv._1)
+ private val nameToColInfo: Map[String, (Attribute, ColumnStat)] =
+ columnInfo.map(kv => kv._1.name -> kv)
+
+ // Suppose table1 (key-1-5 int, key-5-9 int) has 5 records: (1, 9), (2,
8), (3, 7), (4, 6), (5, 5)
+ private val table1 = StatsTestPlan(
+ outputList = Seq("key-1-5", "key-5-9").map(nameToAttr),
+ rowCount = 5,
+ attributeStats = AttributeMap(Seq("key-1-5",
"key-5-9").map(nameToColInfo)))
+
+ // Suppose table2 (key-1-2 int, key-2-4 int) has 3 records: (1, 2), (2,
3), (2, 4)
+ private val table2 = StatsTestPlan(
+ outputList = Seq("key-1-2", "key-2-4").map(nameToAttr),
+ rowCount = 3,
+ attributeStats = AttributeMap(Seq("key-1-2",
"key-2-4").map(nameToColInfo)))
+
+ // Suppose table3 (key-1-2 int, key-2-3 int) has 2 records: (1, 2), (2,
3)
+ private val table3 = StatsTestPlan(
+ outputList = Seq("key-1-2", "key-2-3").map(nameToAttr),
+ rowCount = 2,
+ attributeStats = AttributeMap(Seq("key-1-2",
"key-2-3").map(nameToColInfo)))
+
+ test("cross join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ val join = Join(table1, table2, Cross, None)
+ val expectedStats = Statistics(
+ sizeInBytes = 5 * 3 * (8 + 4 * 4),
+ rowCount = Some(5 * 3),
+ // Keep the column stat from both sides unchanged.
+ attributeStats = AttributeMap(
+ Seq("key-1-5", "key-5-9", "key-1-2",
"key-2-4").map(nameToColInfo)))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("disjoint inner join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // key-5-9 and key-2-4 are disjoint
+ val join = Join(table1, table2, Inner,
+ Some(EqualTo(nameToAttr("key-5-9"), nameToAttr("key-2-4"))))
+ val expectedStats = Statistics(
+ sizeInBytes = 1,
+ rowCount = Some(0),
+ attributeStats = AttributeMap(Nil))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("disjoint left outer join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // key-5-9 and key-2-4 are disjoint
+ val join = Join(table1, table2, LeftOuter,
+ Some(EqualTo(nameToAttr("key-5-9"), nameToAttr("key-2-4"))))
+ val expectedStats = Statistics(
+ sizeInBytes = 5 * (8 + 4 * 4),
+ rowCount = Some(5),
+ attributeStats = AttributeMap(Seq("key-1-5",
"key-5-9").map(nameToColInfo) ++
+ // Null count for right side columns = left row count
+ Seq(nameToAttr("key-1-2") ->
nullColumnStat(nameToAttr("key-1-2").dataType, 5),
+ nameToAttr("key-2-4") ->
nullColumnStat(nameToAttr("key-2-4").dataType, 5))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("disjoint right outer join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // key-5-9 and key-2-4 are disjoint
+ val join = Join(table1, table2, RightOuter,
+ Some(EqualTo(nameToAttr("key-5-9"), nameToAttr("key-2-4"))))
+ val expectedStats = Statistics(
+ sizeInBytes = 3 * (8 + 4 * 4),
+ rowCount = Some(3),
+ attributeStats = AttributeMap(Seq("key-1-2",
"key-2-4").map(nameToColInfo) ++
+ // Null count for left side columns = right row count
+ Seq(nameToAttr("key-1-5") ->
nullColumnStat(nameToAttr("key-1-5").dataType, 3),
+ nameToAttr("key-5-9") ->
nullColumnStat(nameToAttr("key-5-9").dataType, 3))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("disjoint full outer join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // key-5-9 and key-2-4 are disjoint
+ val join = Join(table1, table2, FullOuter,
+ Some(EqualTo(nameToAttr("key-5-9"), nameToAttr("key-2-4"))))
+ val expectedStats = Statistics(
+ sizeInBytes = (5 + 3) * (8 + 4 * 4),
+ rowCount = Some(5 + 3),
+ attributeStats = AttributeMap(
+ // Update null count in column stats.
+ Seq(nameToAttr("key-1-5") ->
columnInfo(nameToAttr("key-1-5")).copy(nullCount = 3),
+ nameToAttr("key-5-9") ->
columnInfo(nameToAttr("key-5-9")).copy(nullCount = 3),
+ nameToAttr("key-1-2") ->
columnInfo(nameToAttr("key-1-2")).copy(nullCount = 5),
+ nameToAttr("key-2-4") ->
columnInfo(nameToAttr("key-2-4")).copy(nullCount = 5))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("inner join") {
+ // table1 (key-1-5 int, key-5-9 int): (1, 9), (2, 8), (3, 7), (4, 6),
(5, 5)
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ val join = Join(table1, table2, Inner,
+ Some(EqualTo(nameToAttr("key-1-5"), nameToAttr("key-1-2"))))
+ // Update column stats for equi-join keys (key-1-5 and key-1-2).
+ val joinedColStat = ColumnStat(distinctCount = 2, min = Some(1), max =
Some(2), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+ // Update column stat for other column if #outputRow / #sideRow < 1
(key-5-9), or keep it
+ // unchanged (key-2-4).
+ val colStatForkey59 = nameToColInfo("key-5-9")._2.copy(distinctCount =
5 * 3 / 5)
+
+ val expectedStats = Statistics(
+ sizeInBytes = 3 * (8 + 4 * 4),
+ rowCount = Some(3),
+ attributeStats = AttributeMap(
+ Seq(nameToAttr("key-1-5") -> joinedColStat, nameToAttr("key-1-2")
-> joinedColStat,
+ nameToAttr("key-5-9") -> colStatForkey59,
nameToColInfo("key-2-4"))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("inner join with multiple equi-join keys") {
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // table3 (key-1-2 int, key-2-3 int): (1, 2), (2, 3)
+ val join = Join(table2, table3, Inner, Some(
+ And(EqualTo(nameToAttr("key-1-2"), nameToAttr("key-1-2")),
+ EqualTo(nameToAttr("key-2-4"), nameToAttr("key-2-3")))))
+
+ // Update column stats for join keys.
+ val joinedColStat1 = ColumnStat(distinctCount = 2, min = Some(1), max
= Some(2), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+ val joinedColStat2 = ColumnStat(distinctCount = 2, min = Some(2), max
= Some(3), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+
+ val expectedStats = Statistics(
+ sizeInBytes = 2 * (8 + 4 * 4),
+ rowCount = Some(2),
+ attributeStats = AttributeMap(
+ Seq(nameToAttr("key-1-2") -> joinedColStat1, nameToAttr("key-1-2")
-> joinedColStat1,
+ nameToAttr("key-2-4") -> joinedColStat2, nameToAttr("key-2-3")
-> joinedColStat2)))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("left outer join") {
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // table3 (key-1-2 int, key-2-3 int): (1, 2), (2, 3)
+ val join = Join(table3, table2, LeftOuter,
+ Some(EqualTo(nameToAttr("key-2-3"), nameToAttr("key-2-4"))))
+ val joinedColStat = ColumnStat(distinctCount = 2, min = Some(2), max =
Some(3), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+
+ val expectedStats = Statistics(
+ sizeInBytes = 2 * (8 + 4 * 4),
+ rowCount = Some(2),
+ // Keep the column stat from left side unchanged.
+ attributeStats = AttributeMap(
+ Seq(nameToColInfo("key-1-2"), nameToColInfo("key-2-3"),
+ nameToColInfo("key-1-2"), nameToAttr("key-2-4") ->
joinedColStat)))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("right outer join") {
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // table3 (key-1-2 int, key-2-3 int): (1, 2), (2, 3)
+ val join = Join(table2, table3, RightOuter,
+ Some(EqualTo(nameToAttr("key-2-4"), nameToAttr("key-2-3"))))
+ val joinedColStat = ColumnStat(distinctCount = 2, min = Some(2), max =
Some(3), nullCount = 0,
+ avgLen = 4, maxLen = 4)
+
+ val expectedStats = Statistics(
+ sizeInBytes = 2 * (8 + 4 * 4),
+ rowCount = Some(2),
+ // Keep the column stat from right side unchanged.
+ attributeStats = AttributeMap(
+ Seq(nameToColInfo("key-1-2"), nameToAttr("key-2-4") ->
joinedColStat,
+ nameToColInfo("key-1-2"), nameToColInfo("key-2-3"))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("full outer join") {
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // table3 (key-1-2 int, key-2-3 int): (1, 2), (2, 3)
+ val join = Join(table2, table3, FullOuter,
+ Some(EqualTo(nameToAttr("key-2-4"), nameToAttr("key-2-3"))))
+
+ val expectedStats = Statistics(
+ sizeInBytes = 3 * (8 + 4 * 4),
+ rowCount = Some(3),
+ // Keep the column stat from both sides unchanged.
+ attributeStats = AttributeMap(Seq(nameToColInfo("key-1-2"),
nameToColInfo("key-2-4"),
+ nameToColInfo("key-1-2"), nameToColInfo("key-2-3"))))
+ assert(join.stats(conf) == expectedStats)
+ }
+
+ test("left semi/anti join") {
+ // table2 (key-1-2 int, key-2-4 int): (1, 2), (2, 3), (2, 4)
+ // table3 (key-1-2 int, key-2-3 int): (1, 2), (2, 3)
+ Seq(LeftSemi, LeftAnti).foreach { jt =>
+ val join = Join(table2, table3, jt,
+ Some(EqualTo(nameToAttr("key-2-4"), nameToAttr("key-2-3"))))
+ // For now we just propagate the statistics from left side for left
semi/anti join.
+ val expectedStats = Statistics(
+ sizeInBytes = 3 * (8 + 4 * 2),
+ rowCount = Some(3),
+ attributeStats = AttributeMap(Seq(nameToColInfo("key-1-2"),
nameToColInfo("key-2-4"))))
+ assert(join.stats(conf) == expectedStats)
+ }
+ }
+
+ test("test join keys of different types") {
+ val dec1 = new java.math.BigDecimal("1.000000000000000000")
+ val dec2 = new java.math.BigDecimal("8.000000000000000000")
+ val d1 = Date.valueOf("2016-05-08")
+ val d2 = Date.valueOf("2016-05-09")
+ val t1 = Timestamp.valueOf("2016-05-08 00:00:01")
+ val t2 = Timestamp.valueOf("2016-05-09 00:00:02")
+
+ /** Columns in a table with only one row */
+ val columnInfo1 = mutable.LinkedHashMap[Attribute, ColumnStat](
+ AttributeReference("cbool", BooleanType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(false), max = Some(false), nullCount = 0, avgLen = 1,
maxLen = 1),
+ AttributeReference("cbyte", ByteType)() -> ColumnStat(distinctCount
= 1,
+ min = Some(1L), max = Some(1L), nullCount = 0, avgLen = 1, maxLen
= 1),
+ AttributeReference("cshort", ShortType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(1L), max = Some(1L), nullCount = 0, avgLen = 2, maxLen
= 2),
+ AttributeReference("cint", IntegerType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(1L), max = Some(1L), nullCount = 0, avgLen = 4, maxLen
= 4),
+ AttributeReference("clong", LongType)() -> ColumnStat(distinctCount
= 1,
+ min = Some(1L), max = Some(1L), nullCount = 0, avgLen = 8, maxLen
= 8),
+ AttributeReference("cdouble", DoubleType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(1.0), max = Some(1.0), nullCount = 0, avgLen = 8,
maxLen = 8),
+ AttributeReference("cfloat", FloatType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(1.0), max = Some(1.0), nullCount = 0, avgLen = 4,
maxLen = 4),
+ AttributeReference("cdecimal", DecimalType.SYSTEM_DEFAULT)() ->
ColumnStat(distinctCount = 1,
+ min = Some(dec1), max = Some(dec1), nullCount = 0, avgLen = 16,
maxLen = 16),
+ AttributeReference("cstring", StringType)() ->
ColumnStat(distinctCount = 1,
+ min = None, max = None, nullCount = 0, avgLen = 3, maxLen = 3),
+ AttributeReference("cbinary", BinaryType)() ->
ColumnStat(distinctCount = 1,
+ min = None, max = None, nullCount = 0, avgLen = 3, maxLen = 3),
+ AttributeReference("cdate", DateType)() -> ColumnStat(distinctCount
= 1,
+ min = Some(d1), max = Some(d1), nullCount = 0, avgLen = 4, maxLen
= 4),
+ AttributeReference("ctimestamp", TimestampType)() ->
ColumnStat(distinctCount = 1,
+ min = Some(t1), max = Some(t1), nullCount = 0, avgLen = 8, maxLen
= 8)
+ )
+
+ /** Columns in a table with two rows */
+ val columnInfo2 = mutable.LinkedHashMap[Attribute, ColumnStat](
--- End diff --
are these totally same with the `columnInfo1`? may we can create a method
to do this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
