Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r101360777
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -742,7 +742,7 @@ public boolean append(Object kbase, long koff, int
klen, Object vbase, long voff
longArray.set(pos * 2 + 1, keyHashcode);
isDefined = true;
- if (numKeys > growthThreshold && longArray.size() < MAX_CAPACITY) {
+ if (numKeys >= growthThreshold && longArray.size() < MAX_CAPACITY)
{
--- End diff --
Unfortunately, we can't grow in the beginning, otherwise the `pos` will be
wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
