Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14412#discussion_r101446961
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1131,14 +1131,43 @@ private[spark] class BlockManager(
}
/**
+ * Called for pro-active replenishment of blocks lost due to executor
failures
+ *
+ * @param blockId blockId being replicate
+ * @param existingReplicas existing block managers that have a replica
+ * @param maxReplicas maximum replicas needed
+ * @return
+ */
+ def replicateBlock(
+ blockId: BlockId,
+ existingReplicas: Set[BlockManagerId],
+ maxReplicas: Int): Unit = {
+ logInfo(s"Pro-actively replicating $blockId")
+ val infoForReplication = blockInfoManager.lockForReading(blockId).map
{ info =>
+ val data = doGetLocalBytes(blockId, info)
+ val storageLevel = StorageLevel(
+ info.level.useDisk,
--- End diff --
Minor nit, but a problem with the `StorageLevel` constructor is that it has
a bunch of adjacent boolean parameters, so in such cases I'd usually prefer to
name all of the parameters explicitly at the call site in order to avoid errors
should these lines get permuted / to convince readers that the API is being
used correctly.
Thus I'd probably write each line like `useDisk = info.level.useDisk,` etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
