Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16722#discussion_r101449037
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
    @@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
           subsamplingRate: Double,
           numSubsamples: Int,
           withReplacement: Boolean,
    +      extractSampleWeight: (Datum => Double) = (_: Datum) => 1.0,
           seed: Long = Utils.random.nextLong()): RDD[BaggedPoint[Datum]] = {
    +    // TODO: implement weighted bootstrapping
    --- End diff --
    
    There was some discussion on the JIRA about it. Actually, we may or may not 
do this, so I'll remove it in the next commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to