Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2366#discussion_r17498282
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
    @@ -1228,4 +1240,212 @@ class BlockManagerSuite extends FunSuite with 
Matchers with BeforeAndAfter
         assert(unrollMemoryAfterB6 === unrollMemoryAfterB4)
         assert(unrollMemoryAfterB7 === unrollMemoryAfterB4)
       }
    +
    +  test("get peers with store addition and removal") {
    --- End diff --
    
    mind calling this BlockManager instead of store? I think most people don't 
call it store actually


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to