Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16961#discussion_r101597310
--- Diff:
examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java ---
@@ -40,7 +38,7 @@
*/
public final class JavaLogQuery {
- public static final List<String> exampleApacheLogs = Lists.newArrayList(
+ public static final List<String> exampleApacheLogs = Arrays.asList(
--- End diff --
Although this isn't specific to Java 8, the existence of Arrays.asList
should mean we don't need Guava's Lists.newArrayList, and, we should prefer
examples that don't involve third party libraries.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
