Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16962#discussion_r101622507
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -573,6 +575,24 @@ final class DataFrameWriter[T] private[sql](ds: 
Dataset[T]) {
         format("csv").save(path)
       }
     
    +  private def runCommand(session: SparkSession, name: String)(command: 
LogicalPlan): Unit = {
    +    val qe = session.sessionState.executePlan(command)
    +    try {
    +      qe.executedPlan.foreach { plan =>
    +        plan.resetMetrics()
    --- End diff --
    
    just realized that, in this code path, we pass in a logical plan and will 
always get a new physical plan, so we don't need to reset metrics here, let me 
remove it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to