Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2373#discussion_r17504372
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -121,7 +124,7 @@ private[yarn] abstract class YarnAllocator(
logDebug("Empty allocation request ...")
}
- val allocateResponse = allocateContainers(missing)
+ val allocateResponse = allocateContainers(missing, executorsPending)
--- End diff --
I just thought it would simplify the method signatures. Right now the
stable code takes in a parameter that it doesn't use, and in the alpha code all
we do with those two parameters is add them together anyway. The number of
pending container requests is a property of the allocator, so I think it makes
sense if all methods in the class have access to this. (Not a huge deal)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
