Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16975#discussion_r101860376
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -466,7 +466,7 @@ object SparkSubmit extends CommandLineUtils {
           // Other options
           OptionAssigner(args.executorCores, STANDALONE | YARN, 
ALL_DEPLOY_MODES,
             sysProp = "spark.executor.cores"),
    -      OptionAssigner(args.executorMemory, STANDALONE | MESOS | YARN, 
ALL_DEPLOY_MODES,
    +      OptionAssigner(args.executorMemory, ALL_CLUSTER_MGRS, 
ALL_DEPLOY_MODES,
    --- End diff --
    
    Well, it would make `local-cluster[]` work like any other master, where you 
have to explicitly set the executor memory. I understand the desire to simplify 
things, but this is doing it at the cost of being inconsistent with other 
cluster managers.
    
    (e.g. the same command line with a different master would behave 
differently - you'd fall back to having 1g of memory for executors instead of 
whatever was defined in the `local-cluster` string.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to