Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r101879811
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala ---
@@ -123,4 +126,95 @@ class SparkSessionBuilderSuite extends SparkFunSuite {
session.stop()
}
}
+
+ test("fork new session and inherit a copy of the session state") {
+ val activeSession =
SparkSession.builder().master("local").getOrCreate()
+ val forkedSession = activeSession.cloneSession()
+
+ assert(forkedSession ne activeSession)
+ assert(forkedSession.sessionState ne activeSession.sessionState)
+
+ forkedSession.stop()
+ activeSession.stop()
+ }
+
+ test("fork new session and inherit sql config options") {
--- End diff --
For each other these state, you have to test the following.
- whether the state gets copied over and is usable
- whether the original session is unaffected by changes to clones session,
AND vice versa.
I think the last one is missing in these tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
