Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16979#discussion_r101882783
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -63,8 +63,39 @@ class HDFSMetadataLog[T <: AnyRef :
ClassTag](sparkSession: SparkSession, path:
val metadataPath = new Path(path)
protected val fileManager = createFileManager()
- if (!fileManager.exists(metadataPath)) {
- fileManager.mkdirs(metadataPath)
+ runUninterruptiblyIfLocal {
+ if (!fileManager.exists(metadataPath)) {
+ fileManager.mkdirs(metadataPath)
+ }
+ }
+
+ private def runUninterruptiblyIfLocal[T](body: => T): T = {
+ if (fileManager.isLocalFileSystem) {
+ Thread.currentThread match {
+ case ut: UninterruptibleThread =>
+ // When using a local file system, some file system APIs like
"create" or "mkdirs" must be
--- End diff --
Fixed the comment. I added it in
https://github.com/apache/spark/commit/88c43f4fb5ea042a119819c11a5cdbe225095c54
but it was wrong. We don't need to use `runUninterruptibly ` to workaround
`HADOOP-14084`. The root cause is `HADOOP-10622`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
