Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/16994#discussion_r101935398
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -240,6 +240,7 @@ class BucketedReadSuite extends QueryTest with
SQLTestUtils with TestHiveSinglet
joinCondition: (DataFrame, DataFrame) => Column,
shuffleLeft: Boolean,
shuffleRight: Boolean,
+ numPartitions: Int = 10,
--- End diff --
Since other vars are for left and right side, wondering if same could to be
done for `numPartitions`. ie. `numPartitionsLeft` and `numPartitionsRight`.
That could make the new test you added more interesting :
```
numPartitionsLeft = 1,
numPartitionsRight = 10,
sortLeft = false,
sortRight = true
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
