Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2380#discussion_r17511259
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -217,7 +219,7 @@ private[spark] object JsonProtocol {
("Getting Result Time" -> taskInfo.gettingResultTime) ~
("Finish Time" -> taskInfo.finishTime) ~
("Failed" -> taskInfo.failed) ~
- ("Accumulables" ->
JArray(taskInfo.accumulables.map(accumulableInfoToJson).toList))
+ ("Accumulables" ->
JArray(accumUpdateMap.map(accumulableInfoToJson).toList))
--- End diff --
Why not just remove the unused `accumUpdateMap` instead and preserve the
symmetry? This is a simple getter, which would be inlined anyway. This also
seems very trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
