Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16923#discussion_r102358896
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -106,21 +106,27 @@ private[hive] class HiveClientImpl(
     
         // Set up kerberos credentials for UserGroupInformation.loginUser 
within
         // current class loader
    -    // Instead of using the spark conf of the current spark context, a new
    -    // instance of SparkConf is needed for the original value of 
spark.yarn.keytab
    -    // and spark.yarn.principal set in SparkSubmit, as yarn.Client resets 
the
    -    // keytab configuration for the link name in distributed cache
    -    if (sparkConf.contains("spark.yarn.principal") && 
sparkConf.contains("spark.yarn.keytab")) {
    +    if (sparkConf.contains("spark.yarn.principal")) {
    --- End diff --
    
    One sort of hacky way is to have `ApplicationMaster.scala` override the 
value of `KEYTAB` in the configuration with the value of `AM_KEYTAB`. Then this 
code just needs to look at "spark.yarn.keytab" to cover both cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to