Github user jasonmoore2k commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16714#discussion_r102396498
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -62,18 +62,21 @@ private[spark] object JsonProtocol {
        * JSON serialization methods for SparkListenerEvents |
        * -------------------------------------------------- */
     
    -  def sparkEventToJson(event: SparkListenerEvent): JValue = {
    +  def sparkEventToJson(
    +    event: SparkListenerEvent,
    +    omitInternalAccums: Boolean = false,
    +    omitUpdatedBlockStatuses: Boolean = false): JValue = {
         event match {
    --- End diff --
    
    stageSubmitted
    stageCompleted
    jobStart
    jobEnd
    
    You didn't seem to use omitInternalAccums/omitUpdatedBlockStatuses in these 
cases, although you had changed the underlying methods to support these flags.  
Intended?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to