Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r102566039
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1152,4 +1173,33 @@ class GeneralizedLinearRegressionTrainingSummary
private[regression] (
"No p-value available for this GeneralizedLinearRegressionModel")
}
}
+
+ /**
+ * Summary table with feature name, coefficient, standard error,
+ * tValue and pValue.
+ */
+ @Since("2.2.0")
+ lazy val summaryTable: DataFrame = {
+ if (isNormalSolver) {
+ var featureNamesLocal = featureNames
+ var coefficients = model.coefficients.toArray
+ var idx = Array.range(0, coefficients.length)
+ if (model.getFitIntercept) {
+ featureNamesLocal = featureNamesLocal :+ Intercept
+ coefficients = coefficients :+ model.intercept
+ // Reorder so that intercept comes first
+ idx = (coefficients.length - 1) +: idx
+ }
+ val result = for (i <- idx.toSeq) yield
+ (featureNamesLocal(i), coefficients(i),
coefficientStandardErrors(i),
+ tValues(i), pValues(i))
+
+ val spark = SparkSession.builder().getOrCreate()
--- End diff --
I'm concerned about this - the current session might not always be the
right one.
If we need an instance of SparkSession it would be preferable in the way
MLReader/BaseReadWrite does:
https://github.com/apache/spark/blob/04ee8cf633e17b6bf95225a8dd77bf2e06980eb3/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala#L59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
