Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17023#discussion_r102603024
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
 ---
    @@ -102,6 +102,15 @@ class JsonFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
           sparkSession.sessionState.conf.sessionLocalTimeZone,
           sparkSession.sessionState.conf.columnNameOfCorruptRecord)
     
    +    // Check a field requirement for corrupt records here to throw an 
exception in a driver side
    +    dataSchema.getFieldIndex(parsedOptions.columnNameOfCorruptRecord).map 
{ corruptFieldIndex =>
    --- End diff --
    
    And.. not a strong preference but maybe put this in `JacksonUtils` and 
rename it `JsonUtils` if @cloud-fan is okay? 
    
    Maybe we could throws an exception as `IlligalArgumentException` in the 
first place and then capture the message with `AnalysisException` (as 
`JacksonUtils.verifySchema` is doing in `StructToJson`). This is not a strong 
opinion too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to