Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r102618617
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -66,7 +66,7 @@ class ResolveSQLOnFile(sparkSession: SparkSession)
extends Rule[LogicalPlan] {
* Preprocess [[CreateTable]], to do some normalization and checking.
*/
case class PreprocessTableCreation(sparkSession: SparkSession) extends
Rule[LogicalPlan] {
- private val catalog = sparkSession.sessionState.catalog
+ private def catalog = sparkSession.sessionState.catalog
--- End diff --
Add comments saying that this should be a def and not a val as this would
introduce circular references..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
