Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r102831400
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -23,21 +23,23 @@ import java.util.UUID
import scala.collection.JavaConverters._
import org.apache.kafka.clients.consumer.ConsumerConfig
-import org.apache.kafka.common.serialization.ByteArrayDeserializer
+import org.apache.kafka.common.serialization.{ByteArrayDeserializer,
BytesSerializer}
import org.apache.spark.internal.Logging
-import org.apache.spark.sql.SQLContext
-import org.apache.spark.sql.execution.streaming.Source
+import org.apache.spark.sql.{DataFrame, SaveMode, SQLContext}
+import org.apache.spark.sql.execution.streaming.{Sink, Source}
import org.apache.spark.sql.sources._
+import org.apache.spark.sql.streaming.OutputMode
import org.apache.spark.sql.types.StructType
/**
* The provider class for the [[KafkaSource]]. This provider is designed
such that it throws
* IllegalArgumentException when the Kafka Dataset is created, so that it
can catch
* missing options even before the query is started.
*/
-private[kafka010] class KafkaSourceProvider extends DataSourceRegister
with StreamSourceProvider
- with RelationProvider with Logging {
+private[kafka010] class KafkaSourceProvider extends DataSourceRegister
+ with StreamSourceProvider with StreamSinkProvider
--- End diff --
nit: better to stack them up
```
with X
with Y
with Z
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
