Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r102844431
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.kafka010
+
+import java.{util => ju}
+import java.util.concurrent.TimeUnit
+
+import scala.collection.mutable
+import scala.collection.mutable.ListBuffer
+
+import org.apache.kafka.clients.producer.{Callback, KafkaProducer,
ProducerRecord, RecordMetadata}
+import org.apache.kafka.common.serialization.ByteArraySerializer
+
+import org.apache.spark.{SparkException, TaskContext}
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.SparkSession
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.execution.{QueryExecution, SQLExecution}
+import org.apache.spark.sql.types.{BinaryType, StringType}
+import org.apache.spark.unsafe.types.UTF8String
+import org.apache.spark.util.Utils
+
+object KafkaWriter extends Logging {
+ val TOPIC_ATTRIBUTE_NAME: String = "topic"
+ val KEY_ATTRIBUTE_NAME: String = "key"
+ val VALUE_ATTRIBUTE_NAME: String = "value"
+ val MAX_OUTSTANDING_WRITES: String = "maxOutstandingWrites"
+ val DEFAULT_MAX_OUTSTANDING_WRITES: Int = 1000
+ val WAIT_FOR_CONFIRMED_WRITE_MS = "waitForConfirmedWriteMs"
+ val DEFAULT_WAIT_FOR_CONFIRMED_WRITE_MS = 1000
+
+ private case class TaskCommitMessage(
+ sparkStageId: Int,
+ sparkPartitionId: Int,
+ writeCommitted: Boolean) extends Serializable
+
+ def write(sparkSession: SparkSession,
+ queryExecution: QueryExecution,
+ kafkaParameters: ju.Map[String, Object],
+ defaultTopic: Option[String] = None): Unit = {
+
+ val schema = queryExecution.logical.output
+ schema.find(p => p.name == TOPIC_ATTRIBUTE_NAME).getOrElse(
+ if (defaultTopic == None) {
+ throw new IllegalArgumentException(s"Default topic required when
no " +
+ s"'$TOPIC_ATTRIBUTE_NAME' attribute is present")
+ } else {
+ Literal(defaultTopic.get, StringType)
+ }
+ ).dataType match {
+ case StringType => // good
+ case _ =>
+ throw new IllegalArgumentException(s"Topic type must be a String")
+ }
+ schema.find(p => p.name == KEY_ATTRIBUTE_NAME).getOrElse(
+ Literal(null, StringType)
+ ).dataType match {
+ case StringType | BinaryType => // good
+ case _ =>
+ throw new IllegalArgumentException(s"$KEY_ATTRIBUTE_NAME attribute
type " +
+ s"must be a String or BinaryType")
+ }
+ val valueField = schema.find(p => p.name ==
VALUE_ATTRIBUTE_NAME).getOrElse(
+ throw new IllegalArgumentException(s"Required attribute
'$VALUE_ATTRIBUTE_NAME' not found")
+ ).dataType match {
+ case StringType | BinaryType => // good
+ case _ =>
+ throw new IllegalArgumentException(s"$VALUE_ATTRIBUTE_NAME
attribute type " +
+ s"must be a String or BinaryType")
+ }
+ SQLExecution.withNewExecutionId(sparkSession, queryExecution) {
+ try {
+ val ret = sparkSession.sparkContext.runJob(queryExecution.toRdd,
+ (taskContext: TaskContext, iter: Iterator[InternalRow]) => {
+ executeTask(
+ iterator = iter,
+ producerConfiguration = kafkaParameters,
+ sparkStageId = taskContext.stageId(),
+ sparkPartitionId = taskContext.partitionId(),
+ sparkAttemptNumber = taskContext.attemptNumber(),
+ inputSchema = schema,
+ defaultTopic = defaultTopic)
+ })
+
+ // logInfo(s"Job ${job.getJobID} committed.")
+ } catch {
+ case cause: Throwable =>
+ // logError(s"Aborting job ${job.getJobID}.", cause)
+ throw new SparkException("Job aborted.", cause)
+ }
+ }
+ }
+
+ /** Writes data out in a single Spark task. */
+ private def executeTask(
+ iterator: Iterator[InternalRow],
+ producerConfiguration: ju.Map[String, Object],
+ sparkStageId: Int,
+ sparkPartitionId: Int,
+ sparkAttemptNumber: Int,
+ inputSchema: Seq[Attribute],
+ defaultTopic: Option[String]): TaskCommitMessage = {
+ val writeTask = new KafkaWriteTask(
+ producerConfiguration, inputSchema, defaultTopic)
+ try {
+ Utils.tryWithSafeFinallyAndFailureCallbacks(block = {
+ // Execute the task to write rows out and commit the task.
+ writeTask.execute(iterator)
+ writeTask.releaseResources()
+ })(catchBlock = {
--- End diff --
why not put the `releaseResources ` in the `finallyBlock` instead of
`catchBlock`? then you can have only one call to `releaseResources`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
