Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16930#discussion_r102863614
  
    --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala 
---
    @@ -133,6 +122,79 @@ class ExecutorSuite extends SparkFunSuite {
           }
         }
       }
    +
    +  test("Gracefully handle error in task deserialization") {
    +    val conf = new SparkConf
    +    val serializer = new JavaSerializer(conf)
    +    val env = createMockEnv(conf, serializer)
    +    val serializedTask = serializer.newInstance().serialize(new 
NonDeserializableTask)
    --- End diff --
    
    can you take the error message as a param to NonDeserializableTask, so the 
magic string can be defined once and used below on line 137? From a quick read 
I thought the one on line 137 was coming from the Spark core code (not from the 
test code)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to