Github user lins05 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17051#discussion_r102888024
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -398,6 +398,27 @@ class FilterEstimationSuite extends
StatsEstimationTestBase {
// For all other SQL types, we compare the entire object directly.
assert(filteredStats.attributeStats(ar) == expectedColStats)
}
- }
+ // If the filter has a binary operator (including those nested inside
+ // AND/OR/NOT), swap the sides of the attribte and the literal,
reverse the
+ // operator, and then check again.
+ val rewrittenFilter = filterNode transformExpressionsDown {
+ case op @ EqualTo(ar: AttributeReference, l: Literal) =>
--- End diff --
ð
I tried to find something like this but failed to, so I resorted to the
current code. Thanks for the tip!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
