Github user HarshSharma8 commented on the issue:

    https://github.com/apache/spark/pull/17058
  
    May be this is right and readable from your point of view, this code is
    returning nothing else, just null again and again as default value if user
    along its other values are not present.
    From my point of view i just let the user know about the default value that
    i am going to use.
    
    On Feb 24, 2017 6:04 PM, "Hyukjin Kwon" <[email protected]> wrote:
    
    > It seems too tirival. The default seems even always null. I don't think
    > this is an improvement if there is no other specific reason. The original
    > codes are more readable to me.
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/17058#issuecomment-282280760>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AKIiQL-Ob-HDj0Jz8ykRo_7frY7qFhT1ks5rfs42gaJpZM4MLI9I>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to