Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16987#discussion_r103013496
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -243,13 +243,20 @@ case class DataSource(
val path = caseInsensitiveOptions.getOrElse("path", {
throw new IllegalArgumentException("'path' is not specified")
})
+ // If we're reading files from outputs of another streaming query,
then it does not make
+ // sense to glob files since we would get files from the metadata
log.
+ // Thus we would figure out whether there exists some metadata log
only when user gives a
+ // non-glob path.
+ val sourceHasMetadata =
+ !SparkHadoopUtil.get.isGlobPath(new Path(path)) &&
hasMetadata(Seq(path))
--- End diff --
I guess `sourceHasMetadata` is generated here is because of `hasMetadata`.
Could you move `hasMetadata` to `object FileStreamSink`? Then you can do it
inside `FileStreamSource`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
