Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r103050652
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -510,8 +510,13 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
         requireTableExists(db, tableDefinition.identifier.table)
         verifyTableProperties(tableDefinition)
     
    +    // Add table metadata such as table schema, partition columns, etc. if 
they aren't already
    +    // present.
    +    val withMetaProps = tableDefinition.copy(
    --- End diff --
    
    Sounds reasonable to me. This would be a new public method only for 
```HiveExternalCatalog```, correct (i.e. it shouldn't be added to the 
```ExternalCatalog``` interface)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to