GitHub user datumbox opened a pull request:
https://github.com/apache/spark/pull/17059
Removed unnecessary castings and refactored checked casts in ALS.
## What changes were proposed in this pull request?
The original ALS was performing unnecessary casting to the user and item
ids because the protected checkedCast() method required a double. I removed the
castings and refactored the method to receive Any and efficiently handle all
permitted numeric values.
## How was this patch tested?
I tested it by running the unit-tests and by manually validating the result
of checkedCast for various legal and illegal values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/datumbox/spark als_casting_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17059
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
