Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r103063798
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -144,11 +145,37 @@ private[hive] class TestHiveSparkSession(
existingSharedState.getOrElse(new SharedState(sc))
}
- // TODO: Let's remove TestHiveSessionState. Otherwise, we are not really
testing the reflection
- // logic based on the setting of CATALOG_IMPLEMENTATION.
+ private def createHiveSessionState: HiveSessionState = {
--- End diff --
why separate function. why not just put inline.
```
override lazy val sessionState: HiveSessionState = {
val testConf = ....
....
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
