Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17060#discussion_r103070909
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -98,7 +98,9 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
/** List of test cases to ignore, in lower cases. */
private val blackList = Set(
- "blacklist.sql" // Do NOT remove this one. It is here to test the
blacklist functionality.
+ "blacklist.sql", // Do NOT remove this one. It is here to test the
blacklist functionality.
+ ".ds_store" // A meta-file that may be created on Mac by Finder
App.
--- End diff --
@srowen I did think about it. If we want to keep the mixed case here in
this list, then we have to change the code later to lowercase both the sides
and then compare ? Would you prefer to change the comparison to the following ?
```
if (blackList.exists(t =>
testCase.name.toLowerCase.contains(t.toLowerCase))) {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
