Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17065#discussion_r103073081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -140,56 +129,56 @@ case class FilterEstimation(plan: Filter,
catalystConf: CatalystConf) extends Lo
* @param condition a single logical expression
* @param update a boolean flag to specify if we need to update
ColumnStat of a column
* for subsequent conditions
- * @return Option[Double] value to show the percentage of rows meeting a
given condition.
+ * @return an optional double value to show the percentage of rows
meeting a given condition.
* It returns None if the condition is not supported.
*/
def calculateSingleCondition(condition: Expression, update: Boolean):
Option[Double] = {
condition match {
// For evaluateBinary method, we assume the literal on the right
side of an operator.
// So we will change the order if not.
- // EqualTo does not care about the order
- case op @ EqualTo(ar: AttributeReference, l: Literal) =>
- evaluateBinary(op, ar, l, update)
- case op @ EqualTo(l: Literal, ar: AttributeReference) =>
- evaluateBinary(op, ar, l, update)
+ // EqualTo/EqualNullSafe does not care about the order
--- End diff --
also support `EqualNullSafe`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
