Github user steveloughran commented on the issue:

    https://github.com/apache/spark/pull/16990
  
    LGTM, though you'd have to go do the full coverage to verify that there's 
not a typo in any of the strings. This is why although Spark has adopted the 
more readable inline strings, I'm more of a fan of the "refer to the constant" 
for both spelling and the ability to locate use though the IDE
    
    That said in [HDFS-9301](https://issues.apache.org/jira/browse/HDFS-9301) 
and [HDFS-6418](https://issues.apache.org/jira/browse/HDFS-6418) I have 
expressed my concerns about HDFS constants, and invariably encountered 
resistance to fixing regressions. core and YARN are stable, and I'll happily 
revert anything there if people complain. 
    
    Note also that deprecation warnings go to a special log, 
`"org.apache.hadoop.conf.Configuration.deprecation"`. Set that to WARN and you 
don't get told off any more.
    
    Finally, I still have no idea why HDFS-531 changed fs.default.name to a new 
mixed case string. It does, well, nothing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to