Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16793#discussion_r103089544
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1307,43 +1307,66 @@ def replace(self, to_replace, value, subset=None):
|null| null|null|
+----+------+----+
"""
- if not isinstance(to_replace, (float, int, long, basestring, list,
tuple, dict)):
+ # Helper functions
+ def all_of(types):
--- End diff --
Maybe give this a doc-string to clarify what all_of does even though its
not user facing better to have a docstring than not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
