Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17072#discussion_r103099256
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -153,7 +153,7 @@ public void writeTo(ByteBuffer buffer) {
*
* Unlike getBytes this will not create a copy the array if this is a
slice.
*/
- public @Nonnull ByteBuffer getByteBuffer() {
+ @Nonnull public ByteBuffer getByteBuffer() {
--- End diff --
The compiler accepts it but I agree that annotations conventionally come
before modifiers. They usually come on the line above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
