Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17076#discussion_r103139054
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -440,19 +440,9 @@ private class LinearSVCAggregator(
private val numFeatures: Int = bcFeaturesStd.value.length
private val numFeaturesPlusIntercept: Int = if (fitIntercept)
numFeatures + 1 else numFeatures
- private val coefficients: Vector = bcCoefficients.value
private var weightSum: Double = 0.0
private var lossSum: Double = 0.0
- require(numFeaturesPlusIntercept == coefficients.size, s"Dimension
mismatch. Coefficients " +
- s"length ${coefficients.size}, FeaturesStd length ${numFeatures},
fitIntercept: $fitIntercept")
-
- private val coefficientsArray = coefficients match {
--- End diff --
Note this eliminates the check for sparse coefficients, but I'm not sure it
was ever necessary. We don't do it in other aggregators, this is a private
class so we don't need to worry about people misusing it. Appreciate other
thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
