GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/17083
[SPARK-19750][UI][branch-2.1] Fix redirect issue from http to https
## What changes were proposed in this pull request?
If spark ui port (4040) is not set, it will choose port number 0, and this
will make https port to also choose 0. And in the current Spark code, it will
use this https port (0) to do redirect, so when redirect triggered, it will
point to a wrong url:
like:
```
/tmp/temp$ wget http://172.27.25.134:55015
--2017-02-23 12:13:54-- http://172.27.25.134:55015/
Connecting to 172.27.25.134:55015... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://172.27.25.134:0/ [following]
--2017-02-23 12:13:54-- https://172.27.25.134:0/
Connecting to 172.27.25.134:0... failed: Can't assign requested address.
Retrying.
--2017-02-23 12:13:55-- (try: 2) https://172.27.25.134:0/
Connecting to 172.27.25.134:0... failed: Can't assign requested address.
Retrying.
--2017-02-23 12:13:57-- (try: 3) https://172.27.25.134:0/
Connecting to 172.27.25.134:0... failed: Can't assign requested address.
Retrying.
--2017-02-23 12:14:00-- (try: 4) https://172.27.25.134:0/
Connecting to 172.27.25.134:0... failed: Can't assign requested address.
Retrying.
```
So instead of using 0 to do redirect, we should pick a bound port instead.
This issue only exists in Spark 2.1-, and can be reproduced in yarn cluster
mode.
## How was this patch tested?
Current redirect UT doesn't verify this issue, so extend current UT to do
correct verification.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerryshao/apache-spark SPARK-19750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17083
----
commit 5408005912c1e369cbf3d77ea490b88f621ee047
Author: jerryshao <ss...@hortonworks.com>
Date: 2017-02-27T10:36:45Z
Fix redirect issue for https
Change-Id: I5306a7553c230811dcada4d9c205b82b2af77c6e
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
