Github user sueann commented on a diff in the pull request:
https://github.com/apache/spark/pull/17090#discussion_r103350775
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -248,18 +248,18 @@ class ALSModel private[ml] (
@Since("1.3.0")
def setPredictionCol(value: String): this.type = set(predictionCol,
value)
+ private val predict = udf { (userFeatures: Seq[Float], itemFeatures:
Seq[Float]) =>
+ if (userFeatures != null && itemFeatures != null) {
+ blas.sdot(rank, userFeatures.toArray, 1, itemFeatures.toArray, 1)
--- End diff --
Good point! But since I copy-pasted this block in this PR, maybe it's okay
to try it out in another PR? At least with what we have here we know it's not a
regression. Want to make sure we get some version of ALS recommendForAll* in
2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
