Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2390#discussion_r17526673
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -229,11 +230,17 @@ private[hive] object HiveQl {
                 SetCommand(Some(key), Some(value))
             }
           } else if (sql.trim.toLowerCase.startsWith("cache table")) {
    -        CacheCommand(sql.trim.drop(12).trim, true)
    +        sql.trim.drop(12).trim.split(" ").toSeq match {
    +          case Seq(tableName) => 
    +            CacheCommand(tableName, true)
    +          case Seq(tableName,as, select@_*) => 
    +            CacheTableAsSelectCommand(tableName,
    +                createPlan(sql.trim.drop(12 + tableName.length() + 
as.length() + 2)))
    +        }
           } else if (sql.trim.toLowerCase.startsWith("uncache table")) {
             CacheCommand(sql.trim.drop(14).trim, false)
           } else if (sql.trim.toLowerCase.startsWith("add jar")) {
    -        AddJar(sql.trim.drop(8).trim)
    +        NativeCommand(sql)
    --- End diff --
    
    Hmm, I guess you probably rebased to an older version of master? We 
definitely shouldn't revert `AddJar` support here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to