Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17067
Thanks much Xiao for the review and comments.
I have made the following changes:
- Separated out the -ve cases from the +ve cases.
- Moved positive tests and also the cases that should be supported into the
SQLQueryTestSuite framework. A new test file columnresolution.sql and the
corresponding master out file is added.
- Clean up the ColumnResolutionSuite to remove cases that are covered in
the SQLQueryTestSuite
- I have kept the -ve cases in the ColumnResolutionSuite because the exprId
shows up in the exception.
- I also wanted to cover a case against a hive serde table so I have kept
those tests in the ColumnResolutionSuite
Please advise if we should move any others. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
