Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17045#discussion_r103411216
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -256,7 +259,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
       }
     
       override def sufficientResourcesRegistered(): Boolean = {
    -    totalCoresAcquired >= maxCores * minRegisteredRatio
    +    totalCoreCount.get >= maxCoresOption.getOrElse(0) * minRegisteredRatio
    --- End diff --
    
    This means return fast most of the time. `totalCoreCount` holds the total 
number of cores in the cluster. With a reasonable max core value this 
inequality will usually hold, right? This means immediate task schedule? In the 
Jira the opposite is described, am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to